Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpenStack credential propagation support #697

Merged
merged 3 commits into from
Dec 27, 2024
Merged

Add OpenStack credential propagation support #697

merged 3 commits into from
Dec 27, 2024

Conversation

bnallapeta
Copy link
Member

@bnallapeta bnallapeta commented Nov 28, 2024 •
edited
Loading

Local Run:

ka get machines
NAME                           CLUSTER         NODENAME                       PROVIDERID                                          PHASE     AGE     VERSION
openstack-dev-cp-0             openstack-dev   openstack-dev-cp-0             openstack:///b52ccc71-566b-4487-a0b8-64b2c08f0e5b   Running   8m29s   v1.30.5+k0s.0
openstack-dev-cp-1             openstack-dev   openstack-dev-cp-1             openstack:///4022efcb-da46-4a99-80f3-2eaf3681238e   Running   8m29s   v1.30.5+k0s.0
openstack-dev-cp-2             openstack-dev   openstack-dev-cp-2             openstack:///87ae87e0-2ac5-4f06-b7ba-970d6dbcab3f   Running   8m29s   v1.30.5+k0s.0
openstack-dev-md-p27j6-6wfn4   openstack-dev   openstack-dev-md-p27j6-6wfn4   openstack:///5c2c51c8-f2c0-48d3-9c8f-ed28db53112a   Running   8m30s   
openstack-dev-md-p27j6-w6qvx   openstack-dev   openstack-dev-md-p27j6-w6qvx   openstack:///2df39a6d-2507-452f-9a0a-fb3e6a5d2052   Running   8m30s   

clusterctl describe cluster openstack-dev -n hmc-system
NAME                                                      READY  SEVERITY  REASON  SINCE  MESSAGE                                                        
Cluster/openstack-dev                                     True                     5m26s                                                                  
├─ClusterInfrastructure - OpenStackCluster/openstack-dev                                                                                                  
├─ControlPlane - K0sControlPlane/openstack-dev-cp                                                                                                         
│ └─3 Machines...                                         True                     7m32s  See openstack-dev-cp-0, openstack-dev-cp-1, ...                 
└─Workers                                                                                                                                                 
  └─MachineDeployment/openstack-dev-md                    True                     110s                                                                   
    └─2 Machines...                                       True                     3m43s  See openstack-dev-md-p27j6-6wfn4, openstack-dev-md-p27j6-w6qvx  

k -n hmc-system get managedclusters.hmc.mirantis.com 
NAME            READY   STATUS
openstack-dev   True    ManagedCluster is ready

eromanova
eromanova requested changes Nov 28, 2024
View reviewed changes
internal/credspropagation/openstack.go Outdated Show resolved Hide resolved
a13x5
a13x5 requested changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@a13x5 a13x5 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several issues with overall logic.
Also I believe the scope of this PR could be broaden a little bit by adding credential passing to the cluster (setIdentityHelmValues function). Currently we're expecting ClusterIdentity object only, this isn't the case with OpenStack provider, so logic should be adjusted/tested. If you prepared another PR with these changes it should be merged first.

internal/credspropagation/common.go Show resolved Hide resolved
internal/credspropagation/openstack.go Outdated Show resolved Hide resolved
internal/credspropagation/openstack.go Outdated Show resolved Hide resolved
internal/credspropagation/openstack.go Outdated Show resolved Hide resolved
internal/credspropagation/openstack.go Outdated Show resolved Hide resolved
@bnallapeta bnallapeta force-pushed the openstack-add-creds branch 6 times, most recently from 0a9c359 to 0555f37 Compare December 3, 2024 11:01
@bnallapeta bnallapeta requested review from a13x5 and eromanova December 4, 2024 04:13
@bnallapeta
Copy link
Member Author

@a13x5 @eromanova Would appreciate if you can take a look at the PR and merge it soon.

eromanova
eromanova reviewed Dec 9, 2024
View reviewed changes
Copy link
Member

@eromanova eromanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment from my side. The rest looks good.

config/dev/openstack-credentials.yaml Outdated Show resolved Hide resolved
@ramessesii2 ramessesii2 mentioned this pull request Dec 9, 2024
Open
@s3rj1k s3rj1k mentioned this pull request Dec 16, 2024
Draft
a13x5
a13x5 previously approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@a13x5 a13x5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved
Additional fixes will be made later

@eromanova eromanova self-requested a review December 19, 2024 08:42
@bnallapeta bnallapeta force-pushed the openstack-add-creds branch 2 times, most recently from 8179522 to ea859a7 Compare December 24, 2024 03:50
zerospiel
zerospiel reviewed Dec 24, 2024
View reviewed changes
Copy link
Member

@zerospiel zerospiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments for network, reading, and memory simplifications

internal/credspropagation/openstack.go Outdated Show resolved Hide resolved
internal/credspropagation/openstack.go Outdated Show resolved Hide resolved
internal/credspropagation/openstack.go Outdated Show resolved Hide resolved
internal/credspropagation/openstack.go Outdated Show resolved Hide resolved
internal/credspropagation/openstack.go Outdated Show resolved Hide resolved
internal/credspropagation/openstack.go Outdated Show resolved Hide resolved
internal/credspropagation/openstack.go Outdated Show resolved Hide resolved
internal/controller/managedcluster_controller.go Outdated Show resolved Hide resolved
@bnallapeta
Copy link
Member Author

Testing once again before I push the changes.

@bnallapeta bnallapeta force-pushed the openstack-add-creds branch 2 times, most recently from 099354f to b9fe1f7 Compare December 27, 2024 05:41
@bnallapeta
Copy link
Member Author

Rebased the PR after the ManagedCluster renaming. Let's wait for the CI 🤞

eromanova
eromanova reviewed Dec 27, 2024
View reviewed changes
internal/controller/clusterdeployment_controller.go Outdated Show resolved Hide resolved
internal/controller/clusterdeployment_controller.go Outdated Show resolved Hide resolved
internal/credspropagation/common.go Outdated Show resolved Hide resolved
internal/credspropagation/openstack.go Outdated Show resolved Hide resolved
@bnallapeta
PR comment - rebase issue fixed
69feb04 
Signed-off-by: Bharath Nallapeta <[email protected]>
@eromanova eromanova merged commit 074f989 into Mirantis:main Dec 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eromanova eromanova eromanova approved these changes

@a13x5 a13x5 a13x5 left review comments

@Kshatrix Kshatrix Awaiting requested review from Kshatrix Kshatrix is a code owner

@zerospiel zerospiel Awaiting requested review from zerospiel zerospiel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Project 2A
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bnallapeta @zerospiel @eromanova @a13x5